Feature/issue 22 #23
Merged
Feature/issue 22 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test for old PR2 transmission types. test/calvin: Added in generated Calvin URDF provided by v4hn test/romeo: Reformatted to match Calvin test
…<gazebo reference="..."/>)
…n the same robot. test: Added in specific test for tranmsissions. Have it print the type. @todo: Make this a unittest.
| @@ -329,7 +329,7 @@ def __init__(self, name=None, visual=None, inertial=None, collision=None, origin | |||
| ]) | |||
|
|
|||
|
|
|||
| class Transmission(xmlr.Object): | |||
| class PR2Transmission(xmlr.Object): | |||
There was a problem hiding this comment.
Is this PR2 specific? I am a bit confused about this. URDF does not have PR2-specific tags.
There was a problem hiding this comment.
See http://wiki.ros.org/urdf/XML/Transmission
The [old] transmission element is an extension to the URDF robot description model.
This extension is used for the PR2 robot.
It looks like they didn't want to break the old usage of the transmission elements.
There was a problem hiding this comment.
Thank you for the clarification!
Merged
Karsten1987
pushed a commit
to Karsten1987/urdfdom
that referenced
this pull request
Nov 15, 2018
Use c++11 instead of boost, bump version to 1.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for #22 described by v4hn. Adds duck-typed parsing for tags so that either the new transmission types can be parse or the old PR2 types can be parsed transparently.
Added in
calvinrobot description, along with test parsing and generated patch, as well as a test parsing both transmission types in the same robot.(After reviewing this old code, I realized that I really need to document this and clean it up so it's a little more understandable!)