Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to build depends on builtin_interfaces #371

Closed
sprhawk opened this issue Mar 14, 2024 · 10 comments
Closed

Failed to build depends on builtin_interfaces #371

sprhawk opened this issue Mar 14, 2024 · 10 comments

Comments

@sprhawk
Copy link

sprhawk commented Mar 14, 2024

[dependencies.builtin_interfaces]

I got failure building on builtin_interfaces. I removed it then it is built successfully.

I'm not sure why it is a dependency of rclrs.

@sprhawk sprhawk closed this as completed Mar 14, 2024
@sprhawk sprhawk reopened this Mar 14, 2024
@maspe36
Copy link
Collaborator

maspe36 commented Mar 14, 2024

I got failure building on builtin_interfaces.

Can you share this failure and maybe your workspace folder structure? I have not seen this error myself

@sprhawk
Copy link
Author

sprhawk commented Mar 15, 2024

I got failure building on builtin_interfaces.

Can you share this failure and maybe your workspace folder structure? I have not seen this error myself

I built whole ROS2 myself in Debian Bookworm

I tried later, more libs like libstatistics_collector didn't get rust subdir built.

@mxgrey
Copy link
Collaborator

mxgrey commented Mar 15, 2024

The vendored version of builtin_interfaces that you're using in your diff was a workaround from early in the development of rclrs that shouldn't be needed anymore.

It sounds like you're trying to build the ros2_rust repo in a single workspace with all the other critical packages of ROS 2. If that's the case you'll need #370 which I opened recently to make that possible. I recommend checking out that branch and doing a clean build (run $ rm -rf build install before building).

@sprhawk
Copy link
Author

sprhawk commented Mar 16, 2024

The vendored version of builtin_interfaces that you're using in your diff was a workaround from early in the development of rclrs that shouldn't be needed anymore.

It sounds like you're trying to build the ros2_rust repo in a single workspace with all the other critical packages of ROS 2. If that's the case you'll need #370 which I opened recently to make that possible. I recommend checking out that branch and doing a clean build (run $ rm -rf build install before building).

Thanks I tried your branch but not clean all build and install, I'll try it again.

@maspe36
Copy link
Collaborator

maspe36 commented Mar 20, 2024

I am not seeing the original problem, but the second problem you describe,

I tried later, more libs like libstatistics_collector didn't get rust subdir built.

I do see. I don't always see it, but when it pops up in my workspace I need to do a clean build to resolve it. Next time my workspace is borked I'll take a closer look.

@mxgrey
Copy link
Collaborator

mxgrey commented Mar 20, 2024

Next time my workspace is borked I'll take a closer look.

I've already narrowed the cause of this down to some bad hygiene in the cmake modules of rosidl_generator_rs. I should have a fix for this relatively soon, ideally today but definitely the end of the week depending on my schedule.

@mxgrey
Copy link
Collaborator

mxgrey commented Mar 20, 2024

I think once #380 is merged we can close this issue.

@jhdcs
Copy link
Collaborator

jhdcs commented Mar 26, 2024

#380 has been merged in.

@sprhawk, would you be able to try this again and let us know if the issue is resolved?

@sprhawk
Copy link
Author

sprhawk commented Mar 26, 2024

#380 has been merged in.

@sprhawk, would you be able to try this again and let us know if the issue is resolved?

Thanks, I'll try it before next week.

@sprhawk
Copy link
Author

sprhawk commented Mar 30, 2024

Awesome ! It is working now !
Thanks!

@sprhawk sprhawk closed this as completed Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants