Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install flake8 on noble from noble-proposed #765

Merged
merged 12 commits into from
Mar 29, 2024

Conversation

claraberendsen
Copy link
Contributor

Description

This PR configures ubuntu distro proposed repository as a source for installing packages that have not been updated in the upstream distribution.
In particular installs flake8 from noble-proposed instead of noble.

@clalancette
Copy link
Contributor

I've rebased this on the latest now that I merged in #764. I also simplified it; we should only need to do this action for noble. Here is a quick CI run on Jammy and Noble to see that it installs what we expect:

  • Jammy Build Status
  • Noble Build Status

claraberendsen and others added 2 commits March 27, 2024 15:54
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette force-pushed the claraberendsen/use-proposed-repository branch from cdb4021 to 45075a4 Compare March 27, 2024 19:54
@clalancette
Copy link
Contributor

All right. I've done some additional work here to ensure that we only install python3-flake8 from proposed. This is still not enough to make this work on noble; we need the rest of the changes from #761 as well. But this is one step closer, so I still think we should get this in.

@clalancette
Copy link
Contributor

Here is simple CI, only on Ubuntu. Jammy is expected to succeed, Noble is expected to fail, but it should at least install python3-flake8 7.0.0:

  • Jammy Build Status
  • Noble Build Status

Copy link
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claraberendsen is the pin-priority for noble-proposed set up correctly by default according to https://wiki.ubuntu.com/Testing/EnableProposed#Selective_upgrading_from_-proposed

I don't see any configuration changes to apt priority in this PR. I believe without setting one any apt installations after the repository is setup will prefer a later version from noble-proposed even if no repo is specified. The article has a method for testing this.

Copy link
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of open questions but however they're answered to the author's satisfaction is sufficient for me.

linux_docker_resources/Dockerfile Outdated Show resolved Hide resolved
linux_docker_resources/Dockerfile Outdated Show resolved Hide resolved
@claraberendsen
Copy link
Contributor Author

@nuclearsandwich Here is the outcome of the research. It seems that the default value for the priority of proposed was 100, which didn't serve our use case.
I've decided to add a priority negative to the proposed source, that way according to how apt interprets priority

  P < 0
           prevents the version from being installed

would make it so that proposed has to be explicitly asked for in order to install from that source.
Here is a run with the latest changes.

Build Status

Copy link
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other nitpick I noticed while reading the job log.

linux_docker_resources/Dockerfile Outdated Show resolved Hide resolved
linux_docker_resources/Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Steven! Ragnarök <nuclearsandwich@users.noreply.github.com>
Signed-off-by: Clara Berendsen <claraberendsen@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Contributor

clalancette commented Mar 28, 2024

CI:

  • Jammy Build Status
  • Noble Build Status

@clalancette
Copy link
Contributor

I'm going ahead and merging this one, so we can make further progress on other changes needed here.

@clalancette clalancette merged commit 558b0b6 into master Mar 29, 2024
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the claraberendsen/use-proposed-repository branch March 29, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants