-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install flake8 on noble from noble-proposed #765
Conversation
2b0c3c4
to
cdb4021
Compare
I've rebased this on the latest now that I merged in #764. I also simplified it; we should only need to do this action for noble. Here is a quick CI run on Jammy and Noble to see that it installs what we expect: |
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
cdb4021
to
45075a4
Compare
All right. I've done some additional work here to ensure that we only install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claraberendsen is the pin-priority for noble-proposed set up correctly by default according to https://wiki.ubuntu.com/Testing/EnableProposed#Selective_upgrading_from_-proposed
I don't see any configuration changes to apt priority in this PR. I believe without setting one any apt installations after the repository is setup will prefer a later version from noble-proposed even if no repo is specified. The article has a method for testing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of open questions but however they're answered to the author's satisfaction is sufficient for me.
@nuclearsandwich Here is the outcome of the research. It seems that the default value for the priority of proposed was 100, which didn't serve our use case.
would make it so that proposed has to be explicitly asked for in order to install from that source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other nitpick I noticed while reading the job log.
Co-authored-by: Steven! Ragnarök <nuclearsandwich@users.noreply.github.com> Signed-off-by: Clara Berendsen <claraberendsen@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
I'm going ahead and merging this one, so we can make further progress on other changes needed here. |
Description
This PR configures ubuntu distro proposed repository as a source for installing packages that have not been updated in the upstream distribution.
In particular installs
flake8
from noble-proposed instead of noble.