Skip to content

Conversation

wodtko
Copy link
Contributor

@wodtko wodtko commented Sep 26, 2025

Description

Adding missing entries in the PointField message definition.
The current PCL uses more types than currently available in the message definition.
However, some Python libraries expect to find the datatype values in the message definition.

Fixes #300

Is this user-facing behavior change?

Users may use int64, uint64 and bool in PointClouds and have an easier life decoding them

Did you use Generative AI?

No

Additional Information

https://github.com/PointCloudLibrary/pcl/blob/master/common/include/pcl/type_traits.h
this is where the PCL defines the values

Signed-off-by: Thomas Wodtko <thomas.wodtko@uni-ulm.de>
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this makes sense and align with https://github.com/PointCloudLibrary/pcl/blob/master/common/include/pcl/type_traits.h.

i would like to have another review before merge.

@ahcorde
Copy link
Contributor

ahcorde commented Sep 29, 2025

Pulls: #301
Gist: https://gist.githubusercontent.com/ahcorde/a9fc2011d12d5976e012833cb3dcbcd4/raw/6327e5d0ab9ba999e0fc4d36d68298323eb851be/ros2.repos
BUILD args: --packages-above-and-dependencies sensor_msgs
TEST args: --packages-above sensor_msgs
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17076

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Copy link
Contributor

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filling these out to match pcl's definition makes sense.

@ahcorde ahcorde merged commit fe4712a into ros2:rolling Oct 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MISSING] PointField type entries for PointCloud2 msgs
4 participants