Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in a ported implementation of the PointCloud2Iterator. #34

Merged
merged 4 commits into from
May 9, 2017
Merged

Add in a ported implementation of the PointCloud2Iterator. #34

merged 4 commits into from
May 9, 2017

Conversation

clalancette
Copy link
Contributor

@clalancette clalancette commented May 8, 2017 •
edited
Loading

connects to ros2/ros2#342

CI:
linux: Build Status

@clalancette
Add in a ported implementation of the PointCloud2Iterator.
6428ab8 
Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org>
@clalancette clalancette added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels May 8, 2017
@clalancette
Fix up warnings from cpplint and uncrustify.
7a24276 
Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org>
wjwwood
wjwwood approved these changes May 8, 2017
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend placing a comment (maybe just after the license) which mentions where this file came from:

https://github.com/ros/common_msgs/blob/90063ba9962274e809f91a4045f2d09dd72833c3/sensor_msgs/include/sensor_msgs/point_cloud2_iterator.h

@clalancette
Fix up more warnings from cpplint and uncrustify.
e9dbfbc 
Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org>
@clalancette
Add in a pointer to the original files.
664f279 
Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org>
@clalancette
Copy link
Contributor Author

Before I merge this one up, I realized I needed to do CI on everything, since common_interfaces touches all OSs/distros. Here's the CI for the regular builds:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor Author

All right, so it looks like CI passes. The unstable Windows build is the same sort of error we (often) see on Windows, so I'm going to assume these changes didn't make any change there. Therefore, I'm going to merge this up. Thanks!

@clalancette clalancette merged commit 96a6be9 into master May 9, 2017
@clalancette clalancette deleted the pc2-iterator branch May 9, 2017 17:24
@clalancette clalancette removed the in review Waiting for review (Kanban column) label May 9, 2017
@mikaelarguedas mikaelarguedas mentioned this pull request May 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clalancette @wjwwood