Fixes lifecycle_service_client namespace #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lifecycle demo works as expected with the following commands. terminal 1: ``` ros2 run lifecycle lifecycle_talker ``` terminal 2: ``` ros2 run lifecycle lifecycle_service_client ``` lifecycle_service_client creates clients for /lc_talker/get_state /lc_talker/change_state By providing topic names starting with '/', the clients do not automatically prepend the current namespace. So, the following did not work as expected. terminal 1: ``` ros2 run lifecycle lifecycle_talker __ns:=/foo ``` terminal 2: ``` ros2 run lifecycle lifecycle_service_client __ns:=/foo ``` Results in the error: ``` [ERROR] [foo.lc_client]: Service /lc_talker/change_state is not available. ``` After removing the leading '/' from the lifecycle_service_client topic names, the demo works as expected when providing a namespace. Signed-off-by: cevans87 <c.d.evans87@gmail.com>
|
@tfoote Could someone PTAL at this? |
Karsten1987
approved these changes
Jun 10, 2019
clalancette
pushed a commit
that referenced
this pull request
Jun 12, 2019
The lifecycle demo works as expected with the following commands. terminal 1: ``` ros2 run lifecycle lifecycle_talker ``` terminal 2: ``` ros2 run lifecycle lifecycle_service_client ``` lifecycle_service_client creates clients for /lc_talker/get_state /lc_talker/change_state By providing topic names starting with '/', the clients do not automatically prepend the current namespace. So, the following did not work as expected. terminal 1: ``` ros2 run lifecycle lifecycle_talker __ns:=/foo ``` terminal 2: ``` ros2 run lifecycle lifecycle_service_client __ns:=/foo ``` Results in the error: ``` [ERROR] [foo.lc_client]: Service /lc_talker/change_state is not available. ``` After removing the leading '/' from the lifecycle_service_client topic names, the demo works as expected when providing a namespace. Signed-off-by: cevans87 <c.d.evans87@gmail.com>
clalancette
pushed a commit
that referenced
this pull request
Jun 12, 2019
The lifecycle demo works as expected with the following commands. terminal 1: ``` ros2 run lifecycle lifecycle_talker ``` terminal 2: ``` ros2 run lifecycle lifecycle_service_client ``` lifecycle_service_client creates clients for /lc_talker/get_state /lc_talker/change_state By providing topic names starting with '/', the clients do not automatically prepend the current namespace. So, the following did not work as expected. terminal 1: ``` ros2 run lifecycle lifecycle_talker __ns:=/foo ``` terminal 2: ``` ros2 run lifecycle lifecycle_service_client __ns:=/foo ``` Results in the error: ``` [ERROR] [foo.lc_client]: Service /lc_talker/change_state is not available. ``` After removing the leading '/' from the lifecycle_service_client topic names, the demo works as expected when providing a namespace. Signed-off-by: cevans87 <c.d.evans87@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lifecycle demo works as expected with the following commands.
terminal 1:
terminal 2:
lifecycle_service_client creates clients for
/lc_talker/get_state
/lc_talker/change_state
By providing topic names starting with '/', the clients do not automatically
prepend the current namespace. So, the following did not work as expected.
terminal 1:
terminal 2:
Results in the error:
After removing the leading '/' from the lifecycle_service_client topic names,
the demo works as expected with and without providing a namespace.
Signed-off-by: cevans87 c.d.evans87@gmail.com