Fix armhf build warnings #372
Conversation
|
@emersonknapp - please run this CI job |
|
|
ah - the printf specifiers are tricky - we may need to do an explicit cast on them, if they're using the |
Right. I'll change them to explicit typecasts because changing format specifiers isn't gonna work on all platforms. |
prajakta-gokhale
force-pushed
the
fix-armhf-warnings
branch
from
3586242
to
a8161c8
Compare
|
| printf("Mean latency: %f ns\n", msg->mean_latency); | ||
| printf("Min latency: %lu ns\n", msg->min_latency); | ||
| printf("Max latency: %lu ns\n", msg->max_latency); | ||
| printf("Min latency: %llu ns\n", (long long) msg->min_latency); |
There was a problem hiding this comment.
Instead of doing these C-style casts, I'd much prefer if we used the PRId64 series of macros. That will ensure it will work on all platforms without casts, and is the solution we've used elsewhere in the codebase. The same goes for the changes below.
There was a problem hiding this comment.
Changed in next revision.
Fix armhf build warnings caused by incompatible format specifiers. Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
prajakta-gokhale
force-pushed
the
fix-armhf-warnings
branch
from
a8161c8
to
4f43d66
Compare
Edit: rebuilding "Linux" because the build machine seems to have had a network hiccup. Linux-armhf is strict improvement over upstream. |
|
@clalancette good to merge? |
Fix armhf build warnings caused by incompatible format specifiers. Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
Fix armhf build warnings caused by incorrect format specifiers.
Build warnings seen here.
Related to ros2/ros2#721.
Signed-off-by: Prajakta Gokhale prajaktg@amazon.com