[demo_nodes_cpp] Add YAML launch demos for topics #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damien LaRocque <phicoltan@gmail.com>
IamPhytan
requested review from
adityapande-1995,
audrow and
mjeronimo
as code owners
clalancette
requested changes
Mar 8, 2023
There was a problem hiding this comment.
Can you please rename these files to use _launch.yaml at the end instead? We are trying to move away from the .launch.yaml; see also #588
Comply with current launch file naming standards Signed-off-by: Damien LaRocque <phicoltan@gmail.com>
|
The files have been renamed. I may also rename current launch files to comply with this new standard |
We already have #588 to do that, so no need. |
clalancette
approved these changes
Mar 9, 2023
|
CI:
|
fujitatomoya
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added YAML launch file demos in
demos_nodes_cpp.These launch files were added in order to solve issue #3369 in
ros2_documentation.