Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up -Wcast-qual warning (#193) #197

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Fix up -Wcast-qual warning (#193) #197

merged 1 commit into from
Nov 18, 2019

Conversation

clalancette
Copy link
Contributor

@clalancette clalancette commented Nov 18, 2019

  • Fix up -Wcast-qual warning

  • Change to C++-style cast

Co-Authored-By: Chris Lalancette clalancette@gmail.com

This is the forward-port to ros2 branch of #193

* Fix up -Wcast-qual warning

* Change to C++-style cast

Co-Authored-By: Chris Lalancette <clalancette@gmail.com>
@wuffle-ros wuffle-ros bot added the in review Waiting for review (Kanban column) label Nov 18, 2019
@clalancette
Copy link
Contributor Author

All right. This passed PR testing, passed local testing (both build and test), and was actually tested in #193 (comment) as well. @mjcarroll This should be good to go; once you've approved, I'll merge and then release geometry2 for Eloquent again.

@clalancette clalancette merged commit fb7a193 into ros2 Nov 18, 2019
@wuffle-ros wuffle-ros bot removed the in review Waiting for review (Kanban column) label Nov 18, 2019
@clalancette clalancette deleted the cast-qual-eloquent branch November 18, 2019 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants