Inherit markers from generate_test_description #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it stands, pytest sees rostest tests as a single testing node with no markings. It would be useful if normal pytest markings could be used on the generate_test_description function (where @pytest.mark.rostest and @launch_testing.parametrize are currently specified). Notably, this will always mark the test nodes with 'rostest', and will allow the use of very useful marking like 'xfail', 'skip', and 'skipif'. Signed-off-by: Scott K Logan <logans@cottsay.net>
|
Crola1702
approved these changes
Nov 8, 2022
|
Rebuilding rhel: * Linux-rhel The instability is on the nightlies too: https://ci.ros2.org/view/nightly/job/nightly_linux-rhel_release/1323/testReport/ |
|
@Mergifyio backport humble |
|
@Mergifyio backport galactic |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 17, 2022
(cherry picked from commit f142fd3)
mergify bot
pushed a commit
that referenced
this pull request
Nov 17, 2022
(cherry picked from commit f142fd3) # Conflicts: # launch_testing_ros/launch_testing_ros_pytest_entrypoint.py
✅ Backports have been created
|
cottsay
added a commit
that referenced
this pull request
Nov 23, 2022
(cherry picked from commit f142fd3) Co-authored-by: Scott K Logan <logans@cottsay.net> Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
added a commit
that referenced
this pull request
Nov 23, 2022
(cherry picked from commit f142fd3) Co-authored-by: Scott K Logan <logans@cottsay.net> Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
added a commit
that referenced
this pull request
Nov 24, 2022
(cherry picked from commit f142fd3) Co-authored-by: Scott K Logan <logans@cottsay.net> Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
added a commit
that referenced
this pull request
Nov 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it stands, pytest sees rostest tests as a single testing node with no markings. It would be useful if normal pytest markings could be used on the generate_test_description function (where @pytest.mark.rostest and @launch_testing.parametrize are currently specified).
Notably, this will always mark the test nodes with 'rostest', and will allow the use of very useful marking like 'xfail', 'skip', and 'skipif'.
To duplicate the markers from the entrypoint, this change makes use of the MarkerGenerator singleton (aka
pytest.mark) to create a newMarkerDecoratorwith the same name, then copies the original marker's arguments, which are critical for markers likeskipif.Complements ros2/launch#670