Add dependency on system poco. #18
Conversation
If there is a suitable system version of poco, prefer to use it rather than building poco locally. For bouncy the necessary version of poco is available from the bionic repositories.
nuclearsandwich
added
in review
package.xml
Outdated
| @@ -13,6 +13,7 @@ | |||
|
|
|||
| <buildtool_export_depend>cmake</buildtool_export_depend> | |||
|
|
|||
| <depend>libpoco-dev</depend> | |||
| <depend>pcre</depend> | |||
| <depend>zlib</depend> | |||
There was a problem hiding this comment.
pcre and zlib are pulled in by the upstream poco package so these are only needed when building poco with this package.
My understanding is that they aren't build_depends because this package may build poco at runtime, that is, a downstream developer's build time if it is unavailable.
I think in order to build poco you'll also need libexpat1-dev and libsqlite3-dev. I can either add all build dependencies or remove them all.
|
Thanks for your review @mjcarroll I realized just after when checking this package.xml against the one from ardent that some additional dependencies are needed in the case that poco upstream is not available. |
We're relying on libpoco-dev upstream for this package's release on bionic. The removed dependencies were requirements to build poco but this package should not need to do that in the released configuration. The poco build dependencies have been added to the xenial setup instructions on the ROS 2 wiki instead.
|
@mjcarroll @dirk-thomas ready for a second round of review with the poco build dependencies removed. |
If there is a suitable system version of poco, prefer to use it rather
than building poco locally. For bouncy the necessary version of poco is
available from the bionic repositories.
Necessary to bloom poco_vendor without patching.