Remove most remaining uses of ament_target_dependencies. #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
requested review from
audrow,
ivanpauno and
wjwwood
as code owners
|
CI:
|
Instead, switch to using target_link_libraries everywhere we can. We can't do it for the rmw_implementation substitution, since the libraries aren't always called the same thing as the rmw_implementation. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
force-pushed
the
clalancette/remove-ament-target-deps
branch
from
ec2b32c
to
523e294
Compare
sloretz
approved these changes
Sep 28, 2023
|
New CI after rebase:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, switch to using target_link_libraries everywhere we can. We can't do it for the rmw_implementation substitution, since the libraries aren't always called the same thing as the rmw_implementation.