Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up type_description tests. #1160

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Fix up type_description tests. #1160

merged 1 commit into from
Jun 25, 2024

Conversation

clalancette
Copy link
Contributor

In particular, make sure to match all service_description_init with the appropriate finis. While we are in here, also add in a "service_not_exists" function that will quit much earlier, speeding up the test.

This is essentially a backport of #1107 and parts of #1112, but adapted for Iron.

@Yadunund FYI; this should fix the crashing test on Iron that I found while testing rmw_zenoh.

In particular, make sure to match all service_description_init
with the appropriate finis.  While we are in here, also add in
a "service_not_exists" function that will quit much earlier,
speeding up the test.

This is essentially a backport of #1107
and parts of #1112, but adapted
for Iron.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@clalancette clalancette merged commit 3c5b561 into iron Jun 25, 2024
3 checks passed
@clalancette clalancette deleted the clalancette/fix-tests branch June 25, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants