Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard against bad allocation calling rcl_arguments_copy() #367

Merged
merged 4 commits into from
Jan 4, 2019
Merged

Guard against bad allocation calling rcl_arguments_copy() #367

merged 4 commits into from
Jan 4, 2019

Commits on Dec 21, 2018

  1. [rcl] Add test for copying arguments struct with no arguments

    @jacobperron
    jacobperron committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    7b28d3d View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2018

  1. Override allocate function in test to reveal bug

    @jacobperron
    jacobperron committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    aee8047 View commit details
    Browse the repository at this point in the history

  2. [rcl] Only allocate arrays if there are things to copy in rcl_argumen… 

    …t_copy()

Also guard against freeing invalid pointers if rcl_argument_copy() fails.
    @jacobperron
    jacobperron committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    f08b3d2 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2019

  1. Remove uncessary guard against NULL pointer

    @jacobperron
    jacobperron committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    47a12fe View commit details
    Browse the repository at this point in the history