Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returns CancelResponse::REJECT while goal handle failed to transit to CANCELING state #1641

Merged
merged 3 commits into from
Apr 30, 2021
Merged

Returns CancelResponse::REJECT while goal handle failed to transit to CANCELING state #1641

merged 3 commits into from
Apr 30, 2021

Conversation

KavenYau
Copy link
Contributor

For fixing #1599. Some conversations in #1635 are helpful to this PR.

@KavenYau KavenYau force-pushed the checking-goal-handle-is-cancelable-before-transiting-to-canceling-state branch from 21ef267 to 07bef7b Compare April 26, 2021 12:55
@KavenYau
modify unit test for fixing ros2#1599
d1fe859 
Signed-off-by: Kaven Yau <kavenyau@foxmail.com>
@KavenYau KavenYau force-pushed the checking-goal-handle-is-cancelable-before-transiting-to-canceling-state branch from 39b0bdc to a2634fa Compare April 26, 2021 13:35
@KavenYau
return CancelResponse::REJECT while failed to transit to CANCELING state
8cac085 
Signed-off-by: Kaven Yau <kavenyau@foxmail.com>
@KavenYau KavenYau force-pushed the checking-goal-handle-is-cancelable-before-transiting-to-canceling-state branch from a2634fa to 8cac085 Compare April 27, 2021 06:56
@KavenYau KavenYau changed the title Checking goal handle is cancelable before transiting to canceling state Returns CancelResponse::REJECT while goal handle failed to transit to CANCELING state Apr 27, 2021
fujitatomoya
fujitatomoya approved these changes Apr 27, 2021
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. i guess we could do backport for Galactic/Foxy w/o breaking ABI.

@fujitatomoya
Copy link
Collaborator

@ivanpauno @wjwwood @jacobperron could either of you take a look for another review when you got time?

@KavenYau
add log message for cancel goal failed
ecca6f7 
Signed-off-by: Kaven Yau <kavenyau@foxmail.com>
@KavenYau KavenYau force-pushed the checking-goal-handle-is-cancelable-before-transiting-to-canceling-state branch from 0abe587 to ecca6f7 Compare April 28, 2021 01:02
@KavenYau KavenYau mentioned this pull request Apr 29, 2021
Merged
6 tasks
jacobperron
jacobperron approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an improvement. Thanks for following up 👍

@ivanpauno ivanpauno added this to In progress in Galactic via automation Apr 30, 2021
@ivanpauno ivanpauno added the bug Something isn't working label Apr 30, 2021
@ivanpauno
Copy link
Member

Adding it to the galactic board, I guess we want to backport this.

@ivanpauno
Copy link
Member

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno merged commit d051b8a into ros2:master Apr 30, 2021
@ivanpauno
Copy link
Member

@Mergifyio backport galactic

mergify bot pushed a commit that referenced this pull request Apr 30, 2021
@KavenYau
Returns CancelResponse::REJECT while goal handle failed to transit to…
947750c 
… CANCELING state (#1641)

Signed-off-by: Kaven Yau <kavenyau@foxmail.com>
(cherry picked from commit d051b8a)
@mergify mergify bot mentioned this pull request Apr 30, 2021
Merged
@mergify
Copy link

mergify bot commented Apr 30, 2021

Command backport galactic: success

Backports have been created

ivanpauno pushed a commit that referenced this pull request Apr 30, 2021
@mergify @KavenYau
Returns CancelResponse::REJECT while goal handle failed to transit to…
33de648 
… CANCELING state (#1641) (#1653)

Signed-off-by: Kaven Yau <kavenyau@foxmail.com>
(cherry picked from commit d051b8a)

Co-authored-by: Kaven Yau <kavenyau@foxmail.com>
@KavenYau KavenYau mentioned this pull request Apr 30, 2021
Closed
This was referenced Apr 30, 2021
Closed
Closed
KavenYau added a commit to KavenYau/rclcpp that referenced this pull request May 2, 2021
@KavenYau
Returns CancelResponse::REJECT while goal handle failed to transit to…
79fbd90 
… CANCELING state (ros2#1641)
@clalancette clalancette moved this from In progress to Needs Release in Galactic May 2, 2021
KavenYau added a commit to KavenYau/rclcpp that referenced this pull request May 6, 2021
@KavenYau
Returns CancelResponse::REJECT while goal handle failed to transit to…
bf16d96 
… CANCELING state (ros2#1641)
KavenYau added a commit to KavenYau/rclcpp that referenced this pull request May 6, 2021
@KavenYau
Returns CancelResponse::REJECT while goal handle failed to transit to…
a05c0a5 
… CANCELING state (ros2#1641)

Signed-off-by: Kaven Yau <kavenyau@foxmail.com>
@KavenYau KavenYau mentioned this pull request May 6, 2021
Merged
jacobperron pushed a commit that referenced this pull request May 19, 2021
@KavenYau
Returns CancelResponse::REJECT while goal handle failed to transit to…
1223557 
… CANCELING state (#1641) (#1659)

Signed-off-by: Kaven Yau <kavenyau@foxmail.com>
@clalancette clalancette moved this from Needs Release to Done in Galactic May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

@ivanpauno ivanpauno ivanpauno approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
Galactic
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KavenYau @fujitatomoya @ivanpauno @jacobperron