issue a warning if publishing on a not active publisher

[fmrico]

Hi all,

Issue #552 seems to be blocked. @Myzhar did not a PR with his work. This is a PR with his changes.

This PR provides the machanism to issue a WARN when publishing on a not active publisher.

Best

[Karsten1987]

@fmrico thanks for patch. I believe the same comment for PR #552 applies here:
#562 (comment)

[fmrico]

Hi @Karsten1987 ,

I fixed it following the comments in #562 . Is was not so simple, because I had to change logging macros, to make it compile. Macro has changed to:

::std::is_same<typename std::remove_reference<decltype(logger)>::type, \
    typename ::rclcpp::Logger>::value, \
    "First argument to logging macros must be an rclcpp::Logger")

adding typename, because std::remove_reference<Ty>::type is dependant on a template parameter, as I found here.

I run the tests and everything worked ok.

Best

[Karsten1987]

Great to hear you made it work. The patch looks good to me so far.
I've triggered the buildfarrm to see if this patch introduces any regression on other tests:

CI:

[fmrico]

Thanks @Karsten1987 !!!

[Myzhar]

Great @fmrico 💪