[Foxy] Add check for invalid topic statistics publish period #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add check for invalid topic statistics publish period Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Update documentation Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Address review comments Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Address doc formatting comments Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Update doc spacing Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
|
FYI @wjwwood |
|
@wjwwood could you PTAL when you have the chance? Thanks! |
|
CI:
|
wjwwood
approved these changes
Jun 13, 2020
|
Actually, I had the wrong job link, here's CI with the foxy branches right now to see if those macOS failures are there already: |
|
They are already there, so I'm going to merge this. |
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2020-07-16/15468/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1151
Signed-off-by: Devin Bonnie dbbonnie@amazon.com