small changes to make the publish const reference api work #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
4 tasks
wjwwood
added a commit
that referenced
this pull request
Oct 14, 2015
small changes to make the publish const reference api work
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* ros2GH-118 Make rosbag2::Writer use converters - Use converters in Writer::write() when input rmw serialization format is different from desired storage serialization format - Add new field in rosbag2::StorageOptions to keep track of the rmw format given by the user to store the message in * ros2GH-118 Add --encoding option to ros2 bag record * ros2GH-118 Associate to each topic its rmw_serialization_format - Add 'serialization_format' field to TopicMetadata - Add 'serialization_forat' column in 'topics' table in sqlite storage - Remove 'storage_format' from BagMetadata and use the TopicMetadata field directly, instead - the field 'rmw_serialization_format' has been moved from rosbag2::StorageOptions to rosbag2_transport::RecordOptions, because it's a topic property rather than a storage one. - Currently all topics in a bag file must have the same serialization format - The tests have been updated accordingly * ros2GH-118 Fix tests after rebase * ros2GH-118 Fix MockMetadataIO and use it in test_writer * ros2GH-118 Fix Windows build and minor refactoring * ros2GH-118 Add test for writer to check that error is thrown if converter plugin does not exist * ros2GH-118 Add test to check that metadat_io_ writes metadata file in writer's destructor * ros2GH-118 Build Converter before opening the database in Writer::open() - This assures that if one of the converter plugins does not exist, the database is not created * ros2GH-118 Add end-to-end tests to check graceful failure if converter plugins do not exists - Both a test for record and play has been added * ros2GH-118 Rename 'encoding' CLI option to 'serialization_format' * ros2GH-127 Write serialization format in database also when it's not specified at CLI level - Tests to check that the serialization format is written in the database have also been added. * ros2GH-17 Add leak sanitizer to test - one of the main test goals can only be ssen by valgrind or sanitizers - enable leak sanitizer for gcc builds only (for now) * ros2GH-137: Fix cdr converter plugin - update pluginlib descriptions file after several renames - fix export of missing includes folder * ros2GH-137 Add integration test for cdr converter * ros2GH-137 Fix superfluous printf * ros2GH-137 It suffices to have only one converter test * ros2GH-137 Minor refactoring for better readability of test N.B. This exposes an pre-existing memory leak (not fixed here). * ros2GH-137 Fix memory leak of topic_name - topic_name member needs to be freed - provide a setter for convenience - Directly assigning a string literal in the test is not sufficient as this would be static memory that does not need to be freed. * ros2GH-17 Allow disabling the usage of sanitizers This allows manual usage of valgrind. * ros2GH-17 Fix renaming after rebase * ros2GH-17 Small cleanups (addressing review comments)
mauropasse
pushed a commit
to mauropasse/rclcpp
that referenced
this pull request
Nov 8, 2023
…a-race-events Fix data race in ~EventHandlerBase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/design#56