Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[foxy] Reserve vector capacities and use emplace_back for constructing vectors (#1464) #1489

Merged
merged 1 commit into from
Dec 8, 2020
Merged

[foxy] Reserve vector capacities and use emplace_back for constructing vectors (#1464) #1489

merged 1 commit into from
Dec 8, 2020

Conversation

jacobperron
Copy link
Member

Backport #1464 to Foxy.

@brawner @jacobperron
Reserve vector capacities and use emplace_back for constructing vecto…
d70c075 
…rs (#1464)

* Reserve vector capacities and use emplace_back for constructing vectors

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Use resize instead of reserve

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Remove push_back

Signed-off-by: Stephen Brawner <brawner@gmail.com>
@jacobperron
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

brawner
brawner approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@brawner brawner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Honestly, I don't know why I added it to backports since it's only a performance improvement.

@jacobperron jacobperron merged commit 3dddfd7 into foxy Dec 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the jacob/foxy_backport_1464 branch December 8, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brawner brawner brawner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobperron @brawner