List all parameters #197
Closed
List all parameters #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerkey
added
in review
|
The code looks fine to me. I launched CI jobs: http://ci.ros2.org/job/ci_linux/1042/ |
|
I'm still intending to respond to the comments from #196 about handling the depth argument. |
|
I see, I haven't been following that discussion. |
Don't type-erase request header
…_test Fix flaky subscription and spinning test
Only enable Timer if clock type is steady
* No more fixed guard conditions. * Add notify guard condition to nodes
gerkey
added
in progress
Add mutex to protect vectors of pointers in callbackgroup
… variable expansion
require CMake 3.5
|
Replaced by the same change in #230. |
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
* remove const qualifier for transition states * remove unnecessary const_casts * init and fini function for state and transition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #196 and ros2/system_tests#107.
Add the ability to retrieve the list of all parameters by passing an empty list of prefixes. In that case, the depth argument is ignored. This is one way to do it; other ideas for calling semantics to get the desired behavior?