Allow empty prefix list to get all params; check depth correctly. #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 20, 2016
Closed
gerkey
added
in review
|
lgtm, but that if-statement is getting hairy looking 😄. |
| @@ -271,17 +271,21 @@ Node::list_parameters( | |||
|
|
|||
| // TODO(esteve): define parameter separator, use "." for now | |||
| for (auto & kv : parameters_) { | |||
| if (std::any_of(prefixes.cbegin(), prefixes.cend(), [&kv, &depth](const std::string & prefix) { | |||
| if (((prefixes.size() == 0) && | |||
| ((depth == 0) || | |||
There was a problem hiding this comment.
Please use the constant defined in the service rather then a plain 0 here.
There was a problem hiding this comment.
Matching change in ros2/system_tests@3d1d672
Karsten1987
pushed a commit
that referenced
this pull request
Dec 7, 2016
* Allow empty prefix list to get all params; check depth correctly. * use enum instead of constant
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
valgrind was complaining about some lost memory here. The proposed change should fix it.
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* Add Zstd decompressor * Add unit test to verify decompression works and add unit test to verify it fails with bad input. * Add unit test to check that ZstdDecompressor fails if file uri is bad. * Include example of debug log in comments Signed-off-by: Zachary Michaels <zmichaels11@gmail.com> Co-authored-by: Zachary Michaels <zmichaels11@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #196