Fix ambiguous auto variable on gcc 7.5 #1976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Nogar <stephen.m.nogar.civ@army.mil>
|
@smnogar The linters are unhappy with the length of the line. If you fix that, we can run CI on this and get it in. |
| @@ -816,7 +816,7 @@ class Client : public ClientBase | |||
| "Received invalid sequence number. Ignoring..."); | |||
| return std::nullopt; | |||
| } | |||
| auto value = std::move(it->second.second); | |||
| std::optional<CallbackInfoVariant> value = std::optional<CallbackInfoVariant>{std::move(it->second.second)}; | |||
There was a problem hiding this comment.
I believe that if the type is explicit on the right then auto can be used on the left i.e.
Suggested change
| std::optional<CallbackInfoVariant> value = std::optional<CallbackInfoVariant>{std::move(it->second.second)}; | |
| auto value = std::optional<CallbackInfoVariant>{std::move(it->second.second)}; |
|
@smnogar would you address comments above? thanks! |
|
Since there has been no movement on this in a long time, I'm going to close this out. Feel free to respond to the comments and reopen if you are still interested in getting this in, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm running humble on an older version of embedded linux thats stuck with gcc 7.5. For some reason it didn't like this auto declaration. Could we get this pushed into rolling and humble branches?
This should resolve #1963