-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move event callback binding to PublisherBase and SubscriptionBase #2066
Move event callback binding to PublisherBase and SubscriptionBase #2066
Conversation
Signed-off-by: methylDragon <methylDragon@gmail.com>
Rpr is happy, so I'm happy 😬 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for code maintenance this duplication should be avoided, lgtm with minor comment.
@ivanpauno @hidmic either of you can review on this? |
Signed-off-by: methylDragon <methylDragon@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
APIs we're using changed in ros2/rclcpp#2066 which is released in RCLCPP 18.0.0 in ROS ROlling. This PR uses the updated API.
APIs we're using changed in ros2/rclcpp#2066 which is released in RCLCPP 18.0.0 in ROS ROlling. This PR uses the updated API.
APIs we're using changed in ros2/rclcpp#2066 which is released in RCLCPP 18.0.0 in ROS ROlling. This PR uses the updated API.
The APIs we're using changed in ros2/rclcpp#2066, which is released in rclcpp 18.0.0 in ROS 2 rolling Additionally works around ros2/rosbag2#1242 Co-authored-by: Eric Cousineau <eric.cousineau@tri.global>
This de-duplicates some code