call shutdown in LifecycleNode dtor to avoid leaving the device in unknown state (2nd) #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we can backport this PR to |
mjcarroll
reviewed
May 22, 2024
|
this needs to be rebased to rolling since #2527 is merged. |
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
force-pushed
the
fujitatomoya/lifecycle-node-shutdown-dtor
branch
from
0c57c5f
to
3bd6bef
Compare
|
CI:
|
|
|
@clalancette aarch64 detects many unrelated test failures, is this know issue? [ RUN ] TestNodeParameters.construct_destruct_rcl_errors
mimick: Initialization error: could not find definitions for vital function(s): 'abort' 'vfprintf'
-- run_test.py: return code -6 |
|
https://ci.ros2.org/job/ci_linux-aarch64/15479/ is known issue that can be addressed by ros2/Mimick#36, so retrying CI again. |
|
|
okay now it is green light, merging. |
delete-merged-branch
bot
deleted the
fujitatomoya/lifecycle-node-shutdown-dtor
branch
|
I am gonna do the backport,
|
|
@Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 29, 2024
…known state (2nd) (#2528) * Revert "Revert "call shutdown in LifecycleNode dtor to avoid leaving the device in un… (#2450)" (#2522)" This reverts commit 42b0b57. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * lifecycle node dtor shutdown should be called only in primary state. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * adjust warning message if the node is still in transition state in dtor. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 3bc364a)
This was referenced May 30, 2024
fujitatomoya
added a commit
that referenced
this pull request
Jun 7, 2024
…known state (2nd) (backport #2528) (#2542) * call shutdown in LifecycleNode dtor to avoid leaving the device in unknown state (2nd) (#2528) * Revert "Revert "call shutdown in LifecycleNode dtor to avoid leaving the device in un… (#2450)" (#2522)" This reverts commit 42b0b57. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * lifecycle node dtor shutdown should be called only in primary state. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * adjust warning message if the node is still in transition state in dtor. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 3bc364a) * LifecycleNode shutdown on dtor only with valid context. (#2545) Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
added a commit
that referenced
this pull request
Jun 11, 2024
* Revert "LifecycleNode shutdown on dtor only with valid context. (#2545)" This reverts commit d8d83a0. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * Revert "call shutdown in LifecycleNode dtor to avoid leaving the device in unknown state (2nd) (#2528)" This reverts commit 3bc364a. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
added a commit
that referenced
this pull request
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #2520
depends on #2527