Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rclcpp::shutdown should not be called before LifecycleNode dtor. (backport #2527) #2538

Merged
merged 2 commits into from
May 24, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 24, 2024

address part of #2520


This is an automatic backport of pull request #2527 done by Mergify.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 22df1d5)

# Conflicts:
#	rclcpp_lifecycle/test/test_lifecycle_publisher.cpp
@mergify mergify bot added the conflicts label May 24, 2024
Copy link
Author

mergify bot commented May 24, 2024

Cherry-pick of 22df1d5 has failed:

On branch mergify/bp/humble/pr-2527
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 22df1d59.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rclcpp_lifecycle/test/test_lifecycle_publisher.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@fujitatomoya
Copy link
Collaborator

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya merged commit f95ac7c into humble May 24, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/humble/pr-2527 branch May 24, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant