Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert call shutdown in LifecycleNode destructor (Humble) #2560

Merged
merged 2 commits into from
Jun 12, 2024
Merged

revert call shutdown in LifecycleNode destructor (Humble) #2560

merged 2 commits into from
Jun 12, 2024

Conversation

fujitatomoya
Copy link
Collaborator

revert #2544 and #2491

@fujitatomoya
Revert "lifecycle node dtor shutdown should be called only in primary…
adf6b47 
… state. (#2544)"

This reverts commit 595badb.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Revert "call shutdown in LifecycleNode dtor to avoid leaving the devi…
d3461a9 
…ce in un… (#2450) (#2491)"

This reverts commit 0f9604d.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

fujitatomoya commented Jun 10, 2024 •
edited
Loading

CI (--packages-above-and-dependencies rclcpp_lifecycle):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

This was referenced Jun 10, 2024
Merged
Closed
@fujitatomoya fujitatomoya self-assigned this Jun 10, 2024
@fujitatomoya
Copy link
Collaborator Author

hmmm, Linux-RHEL is not stable... i will give it a shot probably later.

12:03:13 java.nio.channels.ClosedChannelException

@clalancette
Copy link
Contributor

hmmm, Linux-RHEL is not stable... i will give it a shot probably later.

It's already rebuilding as https://ci.ros2.org/job/ci_linux-rhel/735/ . You are just getting unlucky here for some reason. If it happens yet again, I'll ask the infrastructure team to look into it.

@fujitatomoya
Copy link
Collaborator Author

it is likely that i can see CI RHEL hung up with ros2cli ...

image

https://ci.ros2.org/job/ci_linux-rhel/733/console has the same situation.

@fujitatomoya
Copy link
Collaborator Author

CI (test --packages-above-and-dependencies rclcpp_lifecycle --packages-skip ros2cli)

  • Linux-rhel Build Status

@fujitatomoya
Copy link
Collaborator Author

fujitatomoya commented Jun 12, 2024 •
edited
Loading

CI (test --packages-above-and-dependencies rclcpp_lifecycle --packages-above-depth 1)

  • Linux-rhel Build Status

@fujitatomoya
Copy link
Collaborator Author

ignoring CI RHEL for humble for now because it is not stable, all other CIs are green, i will go ahead to merge this.

@fujitatomoya fujitatomoya merged commit 6737773 into humble Jun 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees

@fujitatomoya fujitatomoya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fujitatomoya @clalancette @wjwwood