Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct node name in service test code #2615

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Correct node name in service test code #2615

merged 1 commit into from
Sep 2, 2024

Conversation

Barry-Xu-2018
Copy link
Collaborator

Fix a minor bug in service test.

@Barry-Xu-2018
Correct node name in service test code
33dfd8b 
Signed-off-by: Barry Xu <barry.xu@sony.com>
fujitatomoya
fujitatomoya approved these changes Sep 1, 2024
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

@fujitatomoya
Copy link
Collaborator

Pulls: #2615
Gist: https://gist.githubusercontent.com/fujitatomoya/c9097f65bc96d398a173f91e3960dd7e/raw/3e4842c2aa980570843d5a3b8a830dcae1959c7e/ros2.repos
BUILD args: --packages-up-to rclcpp
TEST args: --packages-select rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14498

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit e846f56 into ros2:rolling Sep 2, 2024
3 checks passed
@ahcorde
Copy link
Contributor

ahcorde commented Sep 2, 2024

https://github.com/Mergifyio backport jazzy

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 2, 2024 •
edited
Loading

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 2, 2024
@Barry-Xu-2018 @mergify
Correct node name in service test code (#2615)
b4f9038 
Signed-off-by: Barry Xu <barry.xu@sony.com>
(cherry picked from commit e846f56)
@mergify mergify bot mentioned this pull request Sep 2, 2024
Merged
ahcorde pushed a commit that referenced this pull request Sep 3, 2024
@mergify @Barry-Xu-2018
Correct node name in service test code (#2615) (#2616)
1b44854 
Signed-off-by: Barry Xu <barry.xu@sony.com>
(cherry picked from commit e846f56)

Co-authored-by: Barry Xu <barry.xu@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@ivanpauno ivanpauno Awaiting requested review from ivanpauno ivanpauno is a code owner

@hidmic hidmic Awaiting requested review from hidmic hidmic is a code owner

@wjwwood wjwwood Awaiting requested review from wjwwood wjwwood is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Barry-Xu-2018 @fujitatomoya @ahcorde