Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose get_node_names API from node. #508

Merged
merged 3 commits into from
Jul 6, 2018
Merged

Conversation

sriramster
Copy link
Contributor

Exposing get_node_names API from node interfaces rather than node_graph ones.

Sriram Raghunathan added 2 commits July 4, 2018 19:41
Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>
Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>
@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Jul 4, 2018
@mikaelarguedas
Copy link
Member

Code change looks good to me.

Though this raises the question of how we want users to access the node_graph API in the future as just forwarding all these functions on the node interface doesn't seem ideal, ticketed at #509

Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sloretz
Copy link
Contributor

sloretz commented Jul 5, 2018

CI (build up to rclcpp, test rclcpp, commit 8bab3a4)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz
Copy link
Contributor

sloretz commented Jul 6, 2018

CI looks ok and change is approved, merging. Thanks for the PR @sriramster !

@sloretz sloretz closed this Jul 6, 2018
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Jul 6, 2018
@sloretz
Copy link
Contributor

sloretz commented Jul 6, 2018

Oops, I failed to click merge (edit: now it's merged)

@sloretz sloretz reopened this Jul 6, 2018
@sloretz sloretz added the in progress Actively being worked on (Kanban column) label Jul 6, 2018
@sloretz sloretz merged commit 93e2945 into ros2:master Jul 6, 2018
@sloretz sloretz removed the in progress Actively being worked on (Kanban column) label Jul 6, 2018
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
* Enable incremental parameter yaml file parsing.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>

* Parse CLI parameter files and overrides in rcl.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>

* Address peer review comments.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
* Document QoS Policy overrides

Signed-off-by: Anas Abou Allaban <aabouallaban@pm.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants