Add types to task.py #1254
Merged
Add types to task.py #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InvincibleRMC
requested review from
sloretz and
adityapande-1995
as code owners
| """ | ||
| Schedule done callbacks on the executor if possible, else run them directly. | ||
|
|
||
| This function assumes self._lock is not held. | ||
| """ | ||
| with self._lock: | ||
| assert self._executor is not None |
There was a problem hiding this comment.
this check is required here? i think this could be None.
There was a problem hiding this comment.
I believe if self._executor is None then an error of 'NoneType' object is not callable would occur with the line executor = self._executor()
| @@ -174,6 +173,7 @@ def add_done_callback(self, callback): | |||
| invoke = False | |||
| with self._lock: | |||
| if self._done: | |||
| assert self._executor is not None | |||
There was a problem hiding this comment.
same here, could be None?
clalancette
approved these changes
Jul 26, 2024
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
|
CI:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.