Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shutdown ThreadPoolExecutor in MultiThreadedExecutor. #1309

Merged

Conversation

fujitatomoya
Copy link
Collaborator

Fixes: #893

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Alex Thiel <apocthiel@gmail.com>
@fujitatomoya
Copy link
Collaborator Author

@ahcorde @clalancette could you take a look at this?

rclpy/rclpy/executors.py Outdated Show resolved Hide resolved
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

@sloretz could you take a look again when you have time?

@fujitatomoya fujitatomoya merged commit ee79763 into rolling Aug 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiThreadedExecutor.shutdown does not shut down underlying threadpool
4 participants