QoS - Minimal change for build against new rcl API #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersonknapp
changed the title
This was referenced Apr 3, 2019
29 tasks
emersonknapp
changed the title
emersonknapp
changed the title
|
@wjwwood This is ready for review. Can you please update the label for us. Thanks. |
jacobperron
added
in review
wjwwood
approved these changes
Apr 24, 2019
sloretz
approved these changes
Apr 24, 2019
emersonknapp
force-pushed
the
qos-0-build-only
branch
from
87b13e9
to
2cc97c4
Compare
wjwwood
approved these changes
Apr 29, 2019
|
@emersonknapp It looks like there is a merge conflict. Mind rebasing? |
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
emersonknapp
force-pushed
the
qos-0-build-only
branch
from
0d502e9
to
4604dbc
Compare
|
Done |
Signed-off-by: Miaofei <miaofei@amazon.com>
wjwwood
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rmw#171
Allows this package to build when new QoS APIs are checked in, but exposes none of the new functionality
Signed-off-by: Emerson Knapp eknapp@amazon.com