Use Pybind11 to generate _rclpy_logging #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 13, 2021
sloretz
changed the title
sloretz
force-pushed
the
prototype_pybind11_logging
branch
from
361508f
to
441ed6f
Compare
|
Rebased on #667 |
34 tasks
sloretz
force-pushed
the
add_pybind11_dependency
branch
from
a11af4b
to
850e84b
Compare
sloretz
force-pushed
the
add_pybind11_dependency
branch
2 times, most recently
from
c04dc58
to
674b02c
Compare
sloretz
force-pushed
the
prototype_pybind11_logging
branch
from
441ed6f
to
d7a7bc4
Compare
cottsay
reviewed
Feb 19, 2021
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
sloretz
force-pushed
the
prototype_pybind11_logging
branch
from
d7a7bc4
to
80cafe0
Compare
|
Rebased + two commits related to #681 CI (build:
|
cottsay
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prototype PR meant to be used for an apples-to-apples comparison with #656.Updated to convert _rclpy_logging to use pybind11, part of #665
@azeey @IanTheEngineer @cottsay FYI