calculate file and directory size #197
Conversation
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
There was a problem hiding this comment.
There's a compilation issue in here on Windows, but that is minor to fix.
What are we trying to accomplish with this? I ask because I'm kind of concerned about this piece of functionality. There are a lot of corner cases here: what about symlinks? How about /dev style files? What about the two different kinds of symlinks on Windows? What happens if one file in the directory is very large, but has its permissions set so the current user can't read it? Also, it seems pretty easy to Denial Of Service the application by creating a directory with many little files. Maybe we can figure out a different way to do this.
|
This code is currently already being used within rosbag2. As per top-level issue description, there are currently three places within ROS2 (
Is there a safe & cross-platform way of getting the file size as well as directory size? I am currently not aware of any other. |
|
Some of this was proposed in rcpputils as well here. |
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
src/filesystem.c
Outdated
| size_t dir_size = 0; | ||
|
|
||
| if (!rcutils_is_directory(directory_path)) { | ||
| fprintf(stderr, "Path is no directory: %s\n", directory_path); |
src/filesystem.c
Outdated
| rcutils_get_file_size(const char * file_path) | ||
| { | ||
| if (!rcutils_is_file(file_path)) { | ||
| fprintf(stderr, "Path is no file: %s\n", file_path); |
|
@clalancette please let me know if you have any further comments on this. CI turns out to be green and both PRs are approved. I just wanted to make sure we can easily address your concerns here in this PR. If it turns out to be a more complex change, I'd propose we open a follow up ticket/PR to this. |
|
@clalancette I am going ahead and merge. Please feel free to come up with a follow up issue for addressing your concerns. |
connects to ros2/rosbag2#248
Signed-off-by: Karsten Knese karsten@openrobotics.org