-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rmw_send_reqponse returns RMW_RET_TIMEOUT. #350
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Actually, I don't think it should return |
How about try-catch the |
@iuhilnehc-ynos yeah i know, we need to think about the client behavior as well. |
@clalancette @mjcarroll this is doc fix for |
@clalancette @mjcarroll this is just doc fix aligns with implementation. there is nothing we do with |
This needs to be put back to humble. (ros2/rcl#1048 has been merged to humble.) |
@Mergifyio backport humble |
✅ Backports have been created
|
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit a0e9788)
part of ros2/ros2#1253, but not dependent.
this is doc fix for
rmw_send_response
to returnRMW_RET_TIMEOUT
.https://github.com/ros2/rmw_fastrtps/blob/926b3a1472fc5ba74972ca8384b054c94571b27c/rmw_fastrtps_shared_cpp/src/rmw_response.cpp#L148-L150
https://github.com/ros2/rmw_cyclonedds/blob/76572ebf1032f359ed302d7017471a295738fa1e/rmw_cyclonedds_cpp/src/rmw_node.cpp#L4541-L4542
RMW_RET_TIMEOUT