Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rmw_send_reqponse returns RMW_RET_TIMEOUT. #350

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

fujitatomoya
Copy link
Collaborator

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@iuhilnehc-ynos
Copy link
Contributor

Actually, I don't think it should return RMW_RET_TIMEOUT right now.
Because there is no argument for users to call the rcl_send_response/rmw_send_response with a timeout value.

@iuhilnehc-ynos
Copy link
Contributor

@fujitatomoya
Copy link
Collaborator Author

@iuhilnehc-ynos yeah i know, we need to think about the client behavior as well.

@fujitatomoya
Copy link
Collaborator Author

@clalancette @mjcarroll this is doc fix for rmw_send_reqponse, can you take a look at this?

@clalancette clalancette self-assigned this Mar 30, 2023
@fujitatomoya
Copy link
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

CI (again, test option was wrong)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

@clalancette @mjcarroll this is just doc fix aligns with implementation. there is nothing we do with RMW_RET_TIMEOUT for now, but rmw implementation does return RMW_RET_TIMEOUT.

@fujitatomoya fujitatomoya merged commit a0e9788 into rolling Apr 4, 2023
@delete-merged-branch delete-merged-branch bot deleted the bugfix-ros2-issues-1253 branch April 4, 2023 21:14
@fujitatomoya
Copy link
Collaborator Author

This needs to be put back to humble. (ros2/rcl#1048 has been merged to humble.)

@fujitatomoya
Copy link
Collaborator Author

@Mergifyio backport humble

Copy link

mergify bot commented May 1, 2024

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 1, 2024
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit a0e9788)
fujitatomoya added a commit that referenced this pull request May 2, 2024
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit a0e9788)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants