Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[foxy] Avoid memory leaks and undefined behavior in rmw_fastrtps_dynamic_cpp typesupport code (#429) #577

Merged
merged 1 commit into from
Feb 3, 2022
Merged

[foxy] Avoid memory leaks and undefined behavior in rmw_fastrtps_dynamic_cpp typesupport code (#429) #577

merged 1 commit into from
Feb 3, 2022

Conversation

jacobperron
Copy link
Member

Backport #429 to Foxy.

@MiguelCompany @jacobperron
Avoid memory leaks and undefined behavior in rmw_fastrtps_dynamic_cpp…
80dfb90 
… typesupport code (#429)

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@jacobperron jacobperron self-assigned this Jan 31, 2022
@jacobperron jacobperron changed the title Avoid memory leaks and undefined behavior in rmw_fastrtps_dynamic_cpp typesupport code (#429) [foxy] Avoid memory leaks and undefined behavior in rmw_fastrtps_dynamic_cpp typesupport code (#429) Jan 31, 2022
@jacobperron
Copy link
Member Author

I'll make a note about the API-break in the patch release announcement and on the Foxy release page.
I'm not too concerned about it since it's not likely people are using the affected headers directly.

@jacobperron jacobperron mentioned this pull request Jan 31, 2022
Merged
@jacobperron
Copy link
Member Author

Add note to Foxy release page: ros2/ros2_documentation#2262

@jacobperron
Copy link
Member Author

jacobperron commented Feb 1, 2022 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit 2a69277 into foxy Feb 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the jacob/foxy_backport_429 branch February 3, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

@hidmic hidmic Awaiting requested review from hidmic

@mjeronimo mjeronimo Awaiting requested review from mjeronimo

Assignees

@jacobperron jacobperron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobperron @ivanpauno @MiguelCompany