Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create crystal release repos file. #624

Merged
merged 2 commits into from
Dec 14, 2018
Merged

Create crystal release repos file. #624

merged 2 commits into from
Dec 14, 2018

Conversation

nuclearsandwich
Copy link
Member

The target crystal branch is currently just a branch off of master.
This PR synchronizes it with the Crystal release.

@nuclearsandwich
Use tagged releases from Crystal distribution.
f5d204b 
Use rosinstall-generator to get list of tags.
This list looks like it pulls the tag from the release stanza rather
than fetching the actual last_release/release_tag from the gbp repo.
Which is mostly right except for Fast-CDR, Fast-RTPS, and googletest.
@nuclearsandwich nuclearsandwich self-assigned this Dec 14, 2018
@nuclearsandwich nuclearsandwich added the in progress Actively being worked on (Kanban column) label Dec 14, 2018
@nuclearsandwich
Copy link
Member Author

nuclearsandwich commented Dec 14, 2018 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status (test failures known and acceptable: Pendulum tests on ARM w/ OpenSplice)
  • Linux Xenial Build Status (test failures known and acceptable: PyQt version on Xenial)
  • Linux-aarch64 Xenial Build Status (test failures known and acceptable: PyQt version on Xenial and Pendulum tests on ARM w/ OpenSplice)
  • macOS Build Status
  • Windows Build Status Looks like cross-vendor tests are more troubled than first thought. Disable any cross-vendor communication tests for Fast-RTPS. system_tests#322 Not a release blocker since system tests are not released.

This was referenced Dec 14, 2018
Closed
Closed
Closed
Closed
nuclearsandwich
nuclearsandwich commented Dec 14, 2018
View reviewed changes
ros2.repos Outdated Show resolved Hide resolved
@hidmic hidmic mentioned this pull request Dec 14, 2018
Closed
@nuclearsandwich nuclearsandwich added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Dec 14, 2018
@nuclearsandwich nuclearsandwich changed the base branch from master to crystal December 14, 2018 22:20
@nuclearsandwich nuclearsandwich merged commit 5e812b7 into crystal Dec 14, 2018
@nuclearsandwich nuclearsandwich deleted the prepare-crystal branch December 14, 2018 22:41
@nuclearsandwich nuclearsandwich removed the in review Waiting for review (Kanban column) label Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

@mjcarroll mjcarroll mjcarroll approved these changes

@tfoote tfoote tfoote approved these changes

@cottsay cottsay cottsay approved these changes

@jacobperron jacobperron jacobperron approved these changes

@sloretz sloretz sloretz approved these changes

@Karsten1987 Karsten1987 Karsten1987 approved these changes

@chapulina chapulina chapulina approved these changes

Assignees

@nuclearsandwich nuclearsandwich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@nuclearsandwich @wjwwood @mjcarroll @tfoote @cottsay @jacobperron @sloretz @Karsten1987 @chapulina