Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Gazebo docs #3342

Closed
wants to merge 1 commit into from
Closed

Updated Gazebo docs #3342

wants to merge 1 commit into from

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Feb 20, 2023

Related with this issue #3340 (comment)

we should not backport this. This changes only affect from Humble

@ahcorde
Updated Gazebo docs
5350118 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Feb 20, 2023
@ahcorde ahcorde mentioned this pull request Feb 20, 2023
Closed
@j-rivero
Copy link
Contributor

Thanks for the PR Alex, a couple of comments:

we should not backport this. This changes only affect from Humble

The PR is targeting rolling. Is this correct given the name of the branch?

More broadly a couple of points:

  • I think that our last PR for clarifying the user installation of Gz distributions could potentially benefit this document in the section of prerequisites. Particularly the new document in Add a document to explain how to install ROS and Gazebo together gazebosim/docs#339 should help people to understand fast which version to install and just run ros-$ROSDISTRO-ros-gz most of the times.

  • I also miss a "where to go from here" link or section where we indicate the users where are more tutorials about the use of ROS and Gazebo.

These two points can be addressed in different PR if you prefer so.

azeey
azeey reviewed Feb 22, 2023
View reviewed changes
source/Tutorials/Advanced/Simulators/Gazebo.rst
@@ -46,19 +46,19 @@ To run this example you should execute the following command in a terminal:

.. code-block:: console

ign gazebo -v 4 -r visualize_lidar.sdf
gz sim -v 4 -r visualize_lidar.sdf
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I commented here, gz will not work for Humble/Fortress so this might cause confusion for the majority of users.

@clalancette
Copy link
Contributor

Based on #3340 (comment) , I'm going to close this one out. Feel free to reopen if you disagree.

@clalancette clalancette deleted the ahcorde/update/gazebo_doc branch May 16, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey azeey left review comments

@clalancette clalancette Awaiting requested review from clalancette clalancette is a code owner

@audrow audrow Awaiting requested review from audrow audrow is a code owner

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahcorde @j-rivero @clalancette @azeey