node name with namespace #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcarroll
approved these changes
Sep 6, 2018
This was referenced Sep 6, 2018
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
* Fix test_node_frontend Fix ros2#145 1. Make test names more intelligible by not parameterizing on a crazy long string 2. Don't leak StringIO objects Signed-off-by: Dan Rose <dan@digilabs.io> * Some renamings and perform the same fixes on test_push_ros_namespace_frontend Signed-off-by: Dan Rose <dan@digilabs.io> * Remove incorrect docstring Signed-off-by: Dan Rose <dan@digilabs.io> * Add copyright for files with contributions Signed-off-by: Dan Rose <dan@digilabs.io> * Fix formatting Signed-off-by: Dan Rose <dan@digilabs.io> * Fix copyrights Signed-off-by: Dan Rose <dan@digilabs.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of ros2/rmw#142.
Proposed to replace #143 and #144.
Fixes #105, fixes #128 and fixes ros2/ros2#569.