Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add topic pub prototype completer #299

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

artivis
Copy link
Contributor

@artivis artivis commented Jul 17, 2019

Add a message prototype completer to ros2 topic pub.
E.g.

$ ros2 topic pub /chatter geometry_msgs/msg/Pose [tab][tab]
-1
-n
--node-name
--once
-p
position:^J  x: 0.0^J  y: 0.0^J  z: 0.0^Jorientation:^J  x: 0.0^J  y: 0.0^J  z: 0.0^J  w: 0.0
--print
--qos-durability
--qos-profile
--qos-reliability
-r
--rate

Not very pretty but one can at least figure out the first few characters of the message body.
Then,

$ ros2 topic pub /chatter geometry_msgs/msg/Pose "p [tab]

resolves to,

ros2 topic pub /chatter geometry_msgs/msg/Pose "position:
  x: 0.0
  y: 0.0
  z: 0.0
orientation:
  x: 0.0
  y: 0.0
  z: 0.0
  w: 0.0"

This follows the work initiated in #298.

Signed-off-by: artivis jeremie.deray@canonical.com

@artivis artivis force-pushed the feature/topic-pub-proto-completer branch from 8c2a921 to d56f4ac Compare July 17, 2019 19:08
@artivis artivis force-pushed the feature/topic-pub-proto-completer branch 2 times, most recently from fe7b2f2 to 3d113f8 Compare July 26, 2019 20:40
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ros2topic/ros2topic/api/__init__.py Outdated Show resolved Hide resolved
Signed-off-by: artivis <jeremie.deray@canonical.com>
@artivis artivis force-pushed the feature/topic-pub-proto-completer branch from 3d113f8 to 3f6341b Compare August 7, 2019 14:59
@artivis
Copy link
Contributor Author

artivis commented Aug 7, 2019

@ivanpauno updated the PR to benefit from ros2/rosidl_python#78

@ivanpauno
Copy link
Member

Sanity check:

  • Linux: Build Status

@ivanpauno ivanpauno merged commit a5b129a into ros2:master Aug 7, 2019
@kyrofa kyrofa mentioned this pull request Sep 4, 2019
34 tasks
@SinaMirrazavi
Copy link

This does not in Foxy apparently, or am I missing something?

@artivis
Copy link
Contributor Author

artivis commented Nov 13, 2020

@sinamr, I believe this is related to issue #563 and PR #570.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants