[ros2topic] Use import message logic provided by rosidl_runtime_py #415
+8
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connects to #218. Note that the action feedback logic in the echo verb was incorrect, resulting in a ModuleImportError. The new logic added in ros2/rosidl_runtime_py#9 should fix the error. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
jacobperron
added
in review
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
Rebuild with latest change for sanity: Edit: I'll wait for new linter errors from an update to be resolved in ros2/rclpy#480 |
hidmic
approved these changes
Dec 9, 2019
| @@ -128,7 +128,7 @@ def subscriber( | |||
| raise RuntimeError( | |||
| 'Could not determine the type for the passed topic') | |||
|
|
|||
| msg_module = import_message_type(topic_name, message_type) | |||
| msg_module = get_message(message_type) | |||
There was a problem hiding this comment.
@jacobperron meta^2: I wonder what'd happen if you used nargs='?', type=get_message above.
There was a problem hiding this comment.
I guess it would be fine if we change this line to msg_module = message_type. But this seems out of scope of this PR. If you'd like to change it in a follow-up, go for it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #218.
Note that the action feedback logic in the echo verb was incorrect, resulting in a ModuleImportError.
The new logic added in ros2/rosidl_runtime_py#9 should fix the error.
Depends on ros2/rosidl_runtime_py#9