Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reapply #659 #661

Merged
merged 2 commits into from
Aug 18, 2021
Merged

Reapply #659 #661

merged 2 commits into from
Aug 18, 2021

Conversation

ivanpauno
Copy link
Member

5eda5f7 fixes the test regressions

@ivanpauno
Revert "Revert "Make the ros2cli output always line buffered (#659)" (#…
31256b8 
…660)"

This reverts commit 0102a4e.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Fix tests
5eda5f7 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the enhancement New feature or request label Aug 17, 2021
@ivanpauno ivanpauno self-assigned this Aug 17, 2021
@fujitatomoya
Copy link
Collaborator

@ivanpauno I confirmed that this fixes ros2param test failure 👍

clalancette
clalancette approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll suggest running full CI on this change, just to be sure there are no other surprises for us.

@ivanpauno
Copy link
Member Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno merged commit 1f4a3aa into master Aug 18, 2021
@ivanpauno ivanpauno deleted the ivanpauno/reapply#659 branch August 18, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@clalancette clalancette clalancette approved these changes

@jacobperron jacobperron Awaiting requested review from jacobperron

Assignees

@ivanpauno ivanpauno

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanpauno @fujitatomoya @clalancette