Subdirectories not installed with ros2pkg's ament_python template

[ijnek]

Currently, the ament_python template has packages=[package_name], as seen below:

ros2cli/ros2pkg/ros2pkg/resource/ament_python/setup.py.em

Line 8 in cf020c0

packages=[package_name],

However, with this configuration, it seems that subdirectories are not installed when running colcon build.

Perhaps it is better to have in the template:

from setuptools import find_packages  # at top of setup.py.em

packages=find_packages(exclude=['test']),

like many ros2 python packages do, including most packages in ros2cli do. Happy to raise a PR if others agree with this change.

Related issue: ros-sports/soccer_ipm#7

[clalancette]

After discussing this, it seems that using find_packages is more standard, so we'd be happy to review a PR that changes this. Note that if we make this change, we'll also have to update the tutorials at https://github.com/ros2/ros2_documentation .

[ijnek]

Thanks for having a discussion about this, I've gone ahead and created a PR in #801 and in ros2/ros2_documentation#3302 to update the docs.