Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated options #824

Merged
merged 2 commits into from
Apr 14, 2023
Merged

remove deprecated options #824

merged 2 commits into from
Apr 14, 2023

Conversation

fujitatomoya
Copy link
Collaborator

just removing options which have been deprecated for humble.

@fujitatomoya
remove deprecated ros2 param dump options.
334ad95 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
remove deprecated ros2 topic echo option.
f5020d0 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

@clalancette @audrow can you do review?

@fujitatomoya fujitatomoya self-assigned this Apr 14, 2023
clalancette
clalancette approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but let's make sure to run CI with --packages-above-and-dependencies ros2param ros2topic just to make sure there are no tests depending on this behavior.

@fujitatomoya
Copy link
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

audrow
audrow approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@fujitatomoya
Copy link
Collaborator Author

@clalancette @audrow do we need to add this Iron Release Note?

@clalancette
Copy link
Contributor

@clalancette @audrow do we need to add this Iron Release Note?

Yeah, that's a good idea.

@fujitatomoya fujitatomoya mentioned this pull request Apr 14, 2023
Merged
@fujitatomoya fujitatomoya merged commit 8c99d15 into rolling Apr 14, 2023
@delete-merged-branch delete-merged-branch bot deleted the fujitatomoya/remove-deprecated-options branch April 14, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audrow audrow audrow approved these changes

@clalancette clalancette clalancette approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs is a code owner

Assignees

@fujitatomoya fujitatomoya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fujitatomoya @clalancette @audrow