Revamp how we get network information in ros2doctor. #910
Conversation
We already depend on psutil, which can give us information for ros2doctor in a cross-platform way. Lean more heavily into using this, which should help us deal with cross-platform a little more smoothly. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
CI:
|
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
Another CI after the fix to flake8:
|
|
Going ahead and merging this one in, thanks for the review. |
|
@clalancette what do you say backport to jazzy, iron and humble? looks like they all have this problem and already use |
The big problem with doing that is that we'd change the output on an already-released distribution. I guess we could kind of reconstruct that information there by putting the |
|
ah that is true. this changes the format, there could be some script or tools relying on the current format for released distros. okay, i am not gonna do this at this moment. |
We already depend on psutil, which can give us information for ros2doctor in a cross-platform way. Lean more heavily into using this, which should help us deal with cross-platform a little more smoothly.
I will note that this slightly changes the output of ros2doctor on Linux. Prior to this PR, the flags output would look something like:
After this PR, the output looks like this:
That is, we lose the decimal bitmask associated with the device.
This should fix #906