Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to add ros2doctor verbs to the extension points. #495

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

clalancette
Copy link
Contributor

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

Without this, ros2 extensions doesn't list ros2doctor.hello as one of the sub-verbs. I think this was just an oversight.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Copy link
Contributor Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Contributor

@claireyywang claireyywang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for fixing this.

@clalancette
Copy link
Contributor Author

All of the build warnings are from other parts of the stack, so this is good to go. Merging.

@clalancette clalancette merged commit e57be12 into master Apr 23, 2020
@clalancette clalancette deleted the register-ros2doctor-extension branch April 23, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants