Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ros2doctor depend on ros_environment and fix platform.py bug on error. #538

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Make ros2doctor depend on ros_environment and fix platform.py bug on error. #538

merged 2 commits into from
Jun 23, 2020

Commits on Jun 22, 2020

  1. Make ros2doctor depend on ros_environment. 

    Since it technically needs ROS_DISTRO defined for it to work,
that means it also has an exec_depend on ros2doctor.  Put that
in here.  Also make the code a little more robust to tests
that may fail and return None.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    1e262be View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. Make sure RosDistroReport returns a valid report on error. 

    That is, it should return the empty ros_report, not "None".

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    99d2d9b View commit details
    Browse the repository at this point in the history