Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer daemon socket ownership on spawn. #652

Merged
merged 4 commits into from
Jul 15, 2021
Merged

Transfer daemon socket ownership on spawn. #652

merged 4 commits into from
Jul 15, 2021

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Jul 12, 2021 •
edited
Loading

This patch is an alternative to #632, transferring socket ownership on spawn to preclude the TOCTOU races that running daemon checks induce.

This patch is functional in my local Linux environment. Let's see what CI (and Windows) have to say:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic
Transfer daemon socket ownership on spawn.
85503fe 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from ivanpauno July 12, 2021 14:57
@hidmic hidmic mentioned this pull request Jul 12, 2021
Closed
@hidmic
Copy link
Contributor Author

hidmic commented Jul 12, 2021

Once CI goes green, I'll document things better.

@hidmic
Fix daemonize() on Windows
9fe2438 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Contributor Author

hidmic commented Jul 12, 2021

Alright, it looks like this is working like a charm 😃

@hidmic hidmic mentioned this pull request Jul 12, 2021
Closed
ivanpauno
ivanpauno reviewed Jul 14, 2021
View reviewed changes
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some comments and questions.
The refactor sounds good to me, but the code is a bit tricky.

ros2cli/ros2cli/daemon/daemonize.py Show resolved Hide resolved
ros2cli/ros2cli/daemon/daemonize.py Show resolved Hide resolved
ros2cli/ros2cli/daemon/__init__.py Show resolved Hide resolved
ros2cli/ros2cli/daemon/__init__.py Show resolved Hide resolved
ros2cli/ros2cli/node/network_aware.py Show resolved Hide resolved
ros2cli/ros2cli/xmlrpc/local_server.py Show resolved Hide resolved
@hidmic
Improve patch and its documentation.
4ceb6fe 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Contributor Author

hidmic commented Jul 14, 2021 •
edited
Loading

CI up to ros2cli:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic hidmic requested a review from ivanpauno July 14, 2021 22:41
@hidmic
Stick to OSError, BrokenPipeError is Unix specific.
4aefe30 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Contributor Author

hidmic commented Jul 15, 2021

Alright, all green. Going in !

@hidmic hidmic merged commit 1e3f1a0 into master Jul 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the hidmic/transfer-daemon-socket-ownership branch July 15, 2021 15:24
@Crola1702 Crola1702 mentioned this pull request Nov 1, 2022
Merged
@ivanpauno ivanpauno mentioned this pull request Dec 15, 2022
Merged
@fujitatomoya fujitatomoya mentioned this pull request Feb 13, 2023
Merged
@iuhilnehc-ynos iuhilnehc-ynos mentioned this pull request Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

@clalancette clalancette Awaiting requested review from clalancette

@audrow audrow Awaiting requested review from audrow audrow is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hidmic @ivanpauno