-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[humble] Use RMW methods to initialize endpoint info (backport #1257) #1275
Conversation
Gist: https://gist.githubusercontent.com/MichaelOrlov/16a912a323c01305ccd5f4ac3b5bfe33/raw/91d3b745ebb54667d4710fcd70c6427802d0e6e3/ros2.repos |
|
We need to do a bunch of releases into Rolling for things to work. That said, Windows CI failed outright, so I don't think this should have been merged. |
@clalancette Windows CI failed because it was to slow and I haven't wait it till it finished and merged this PR. I was pretty assure that Windows CI build will pass. |
So this is the problem; this isn't our process. Our process currently is to wait for Windows CI to complete. I know that Windows is slow, and we are going to look into trying to speed it up. But Windows is the most likely to fail, so merging before Windows is complete is likely to make more work for us at some point.
That's because this action is misconfigured, and is pulling ros2.repos from |
@clalancette Thanks for catching this up. I see you have made fixes for rolling. |
This is an automatic backport of pull request #1257 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com