Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[humble] Use RMW methods to initialize endpoint info (backport #1257) #1275

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Apr 10, 2023

This is an automatic backport of pull request #1257 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…zer to guard against upcoming struct change (#1257)

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
(cherry picked from commit 4932101)
@mergify mergify bot requested a review from a team as a code owner April 10, 2023 20:03
@mergify mergify bot requested review from hidmic and jhdcs and removed request for a team April 10, 2023 20:03
@MichaelOrlov MichaelOrlov changed the title Use RMW methods to initialize endpoint info (backport #1257) [humble] Use RMW methods to initialize endpoint info (backport #1257) Apr 10, 2023
@MichaelOrlov
Copy link
Contributor

Gist: https://gist.githubusercontent.com/MichaelOrlov/16a912a323c01305ccd5f4ac3b5bfe33/raw/91d3b745ebb54667d4710fcd70c6427802d0e6e3/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_transport
TEST args: --packages-above rosbag2_transport
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/11844

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@MichaelOrlov
Copy link
Contributor

build_and_test failed with unrelated errors in rosidl_dynamic_typesupport_fastrtps package.
It seems broken on baseline.
cc: @clalancette a week ago I haven't seen this error at least in #1142
However CI passing green - Since this is a backport and in original PR all jobs passed, merging then.

@MichaelOrlov MichaelOrlov merged commit 77ba8a4 into humble Apr 10, 2023
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/humble/pr-1257 branch April 10, 2023 22:17
@clalancette
Copy link
Contributor

We need to do a bunch of releases into Rolling for things to work.

That said, Windows CI failed outright, so I don't think this should have been merged.

@MichaelOrlov
Copy link
Contributor

MichaelOrlov commented Apr 11, 2023

@clalancette Windows CI failed because it was to slow and I haven't wait it till it finished and merged this PR.
It's failed because at the moment when Windows runner was trying to pull changes from the branch - the branch has already been deleted.

I was pretty assure that Windows CI build will pass.
To prove it I've re-run Windows CI on another branch #1142 (comment) which I rebased on top of latest humble with changes from this PR. It passes green.
However error in rosidl_dynamic_typesupport_fastrtps package still exists https://github.com/ros2/rosbag2/actions/runs/4661768584/jobs/8251418933?pr=1142

@clalancette
Copy link
Contributor

@clalancette Windows CI failed because it was to slow and I haven't wait it till it finished and merged this PR.

So this is the problem; this isn't our process. Our process currently is to wait for Windows CI to complete. I know that Windows is slow, and we are going to look into trying to speed it up. But Windows is the most likely to fail, so merging before Windows is complete is likely to make more work for us at some point.

However error in rosidl_dynamic_typesupport_fastrtps package still exists https://github.com/ros2/rosbag2/actions/runs/4661768584/jobs/8251418933?pr=1142

That's because this action is misconfigured, and is pulling ros2.repos from master (which hasn't been correct for a year now). See #1277 .

@MichaelOrlov
Copy link
Contributor

@clalancette Thanks for catching this up. I see you have made fixes for rolling.
It seems we need to make the same for humble.
I will do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants