Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python binding to close the SequentialWriter #1339

Merged
merged 1 commit into from
May 18, 2023
Merged

Add python binding to close the SequentialWriter #1339

merged 1 commit into from
May 18, 2023

Conversation

Yadunund
Copy link
Member

@Yadunund
Add binding to close the writer
4f6a43a 
Signed-off-by: Yadunund <yadunund@openrobotics.org>
@Yadunund Yadunund requested a review from a team as a code owner May 18, 2023 10:34
@Yadunund Yadunund requested review from emersonknapp and jhdcs and removed request for a team May 18, 2023 10:34
@Yadunund Yadunund mentioned this pull request May 18, 2023
Merged
@MichaelOrlov
Copy link
Contributor

@ros-pull-request-builder retest this please

MichaelOrlov
MichaelOrlov approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelOrlov
Copy link
Contributor

Gist: https://gist.githubusercontent.com/MichaelOrlov/58901fb4df9691add3c91d1a433def9d/raw/6e1f8accecd041b5e6286d37ac871f7eb711a651/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_py
TEST args: --packages-above rosbag2_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12082

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@emersonknapp emersonknapp merged commit 422e754 into rolling May 18, 2023
@delete-merged-branch delete-merged-branch bot deleted the yadu/writer_close_pybind branch May 18, 2023 17:26
@emersonknapp
Copy link
Collaborator

@Mergifyio backport iron

@mergify
Copy link

mergify bot commented May 18, 2023 •
edited
Loading

backport iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 18, 2023
@Yadunund @mergify
Add binding to close the writer (#1339)
388e1ad 
Signed-off-by: Yadunund <yadunund@openrobotics.org>
(cherry picked from commit 422e754)
@mergify mergify bot mentioned this pull request May 18, 2023
Merged
clalancette pushed a commit that referenced this pull request May 18, 2023
@mergify @Yadunund
Add binding to close the writer (#1339) (#1340)
d3fde76 
Signed-off-by: Yadunund <yadunund@openrobotics.org>
(cherry picked from commit 422e754)

Co-authored-by: Yadu <yadunund@openrobotics.org>
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2023-05-18/31587/1

@MichaelOrlov MichaelOrlov mentioned this pull request Jun 1, 2023
Closed
3 tasks
@JannikJose JannikJose mentioned this pull request Oct 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelOrlov MichaelOrlov MichaelOrlov approved these changes

@emersonknapp emersonknapp Awaiting requested review from emersonknapp emersonknapp is a code owner automatically assigned from ros2/tooling-reviewers

@jhdcs jhdcs Awaiting requested review from jhdcs jhdcs is a code owner automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ros2: recording doesn't create metadata.yaml
4 participants
@Yadunund @MichaelOrlov @emersonknapp @ros-discourse