Switch to target_link_libraries everywhere. #1504
Conversation
There is no need to use ament_target_dependencies. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
requested review from
gbiggs and
jhdcs
and removed request for
a team
|
CI:
|
There was a problem hiding this comment.
lgtm
(not related to this PR) https://github.com/ros2/rosbag2/pull/1504/files#diff-81a326226779dbc5abab3808861f8664841bdafaed9ff22ebf59ae30b6233219L281 should be test_msgs_TARGETS, there is a typo. can you also fix that too?
@fujitatomoya Can you paste a new link? For whatever reason, the one above isn't showing me anything other than the lines from this PR. |
|
@clalancette this one, rosbag2/rosbag2_transport/CMakeLists.txt Line 281 in 9855072 |
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Actually, it turns out that that test doesn't depend on test_msgs at all, so I removed the typo along with a couple of other unused dependencies. |
|
New CI with the latest changes:
|
|
@ros-pull-request-builder retest this please |
|
Given that the CI was green, I'm going to go ahead and merge this one. |
|
@clalancette It is ok to merge since the last time rpr job failed with a known issue in the services. |
There is no need to use ament_target_dependencies.